Add call to xAxisPaddingUnit for stack-mixin when calculating max/min #1234
Conversation
When calculating max/min
|
Whoops! Looks like that's the only other use of I didn't realize we weren't testing Hopefully there are already some tests for the bubble chart, box plot, or scatter plot that use a date x axis - I know there are some for the line chart and bar chart. |
| expect(chart.xAxisMax()).toEqual(expectedEndDate); | ||
| }); | ||
|
|
||
| it ('should render the right ') |
There was a problem hiding this comment.
Thanks @stillesjo.
Wow, Jasmine just silently hangs when there's an incomplete test like this one - we should fail the build if there are any pending tests.
There was a problem hiding this comment.
Sorry it isn't ready for merging yet!
I didn't realize that the PR would update with the changes I pushed :(. Just wanted to continue working at home. Sorry about that!
There was a problem hiding this comment.
No problem, I understood that. I'll wait for you to comment before I merge.
Travis went ahead and tested it, and I commented because I was alarmed that our current tools will silently drop tests on the floor. There was another time this happened due to use of an ES6 feature but let doesn't appear to be a problem this time.
I wonder if we need to upgrade our build tools yet again. :-/
There was a problem hiding this comment.
Ah, that might explain it. Added expect(false).toEqual(true); while testing earlier and all tests passed successfully. Changing to var makes tests fails as they should. I'll try to avoid ES6 syntax in the future 😄
There was a problem hiding this comment.
Heheh. Oh I thought it was this dangling it() with no callback and not the let - or maybe it depends on the environment, or the moon.
Anyway, there should be more than 1000 tests, if that number drops there's probably something wrong. It sucks that we have to second guess the test runner, it's supposed to be the other way around!
thanks @stillesjo! with a month test that's plenty for this code path for #1234 note these must get broken when #792 is fixed
|
Thanks @stillesjo, I wrapped up the tests and it's in dc.js 2.0! |
Hi!
We need to get xAxisPaddingUnit when calculating max/min for stack-mixin in order to get xAxisPadding with other units than day to work.
Extends: ea511e0
Reference: #892