Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed numberDisplay tweening getting stuck on Infinity values #1177

Closed
wants to merge 1 commit into from
Closed

Fixed numberDisplay tweening getting stuck on Infinity values #1177

wants to merge 1 commit into from

Conversation

XaserAcheron
Copy link
Contributor

Closes #1176. Basically just added -Infinity and Infinity to the list of values to alias to zero (along with all "falsy" types) for the first parameter of the d3.interpolateNumber call. Works like a charm.

@gordonwoodhull
Copy link
Contributor

@XaserAcheron, I'm adding your example under transitions/ so that we have a visual test (along with a Jasmine test).

gordonwoodhull added a commit that referenced this pull request Jul 27, 2016
gordonwoodhull added a commit that referenced this pull request Jul 27, 2016
@XaserAcheron
Copy link
Contributor Author

Coolness -- I ought to figure out how to do this myself in the future to save you the trouble.

On that note, I'm exceptionally glad the Rush example is now canon. ;P

gordonwoodhull added a commit that referenced this pull request Jul 28, 2016
gordonwoodhull added a commit that referenced this pull request Jul 28, 2016
@gordonwoodhull
Copy link
Contributor

Thanks @XaserAcheron, rebased and merged in 2.0 beta 32!

I'm also very happy to include the Rush example. It's here.

@XaserAcheron XaserAcheron deleted the bugfix-nd-infinity branch May 14, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants