Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix row chart x-axis position on resizing #1001

Merged
merged 1 commit into from
Sep 18, 2015

Conversation

crazycodingcat
Copy link
Contributor

Another small problem in resizing:
When row chart is resized and redrawn, the x-axis position should get updated accordingly.

@gordonwoodhull
Copy link
Contributor

Thanks @crazycodingcat - is there a reason you don't want the moving axis to be animated/transitioned as in your similar for the heatmap #995?

@gordonwoodhull gordonwoodhull modified the milestone: v2.0 Sep 14, 2015
@crazycodingcat
Copy link
Contributor Author

Yes, the moving axis should be animated/transitioned.

I'm making a UI where user can drag the corner of the chart to resize it, and found this bug with the row chart - the x-axis position does not get updated when the height of the chart is changed. I'm using dc.redrawAll() to redraw the charts after the width and height are changed (not sure if this is the best way to do it though). So for the row chart problem, I found this PR as a quick fix without changing too much of the current implementation..

@gordonwoodhull
Copy link
Contributor

Cool, I'll just move the line to the transition part, as you implemented the other one and as I implemented this for bar charts. Thanks!

@gordonwoodhull
Copy link
Contributor

Oh, I see, actually the changing of the height of rows is not animated, so it's probably better not to animate the axis move for now. It's different for the coordinate-grid based charts like the bar chart.

Taking this as-is for now, but it would be nice to animate the height of rows the way the width of bars is already animated.

gordonwoodhull added a commit that referenced this pull request Sep 18, 2015
@gordonwoodhull gordonwoodhull merged commit 1ddf300 into dc-js:master Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants