Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --quiet flag docs and print macro #1102

Closed
1 task done
ehmartens opened this issue Feb 9, 2022 · 5 comments · Fixed by #1319 or #1320
Closed
1 task done

Add --quiet flag docs and print macro #1102

ehmartens opened this issue Feb 9, 2022 · 5 comments · Fixed by #1319 or #1320
Assignees
@runleonarun
Labels
content Improvements or additions to content dbt-core v1.1 Docs impact for the v1.1 release (April 2022) enhancement Use to add new features to the docs size: small This change will take 1 to 2 days to address

Comments

@ehmartens
Copy link

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://github.com/dbt-labs/docs.getdbt.com/blob/current/website/docs/reference/global-configs.md
https://github.com/dbt-labs/docs.getdbt.com/blob/current/website/docs/reference/dbt-jinja-functions.md

What part(s) of the page would you like to see updated?

I'd like to update the documentation to add info about the new global config that PR-4701 will create. Additionally, I'd like to add documentation for the print Jinja function that the PR creates.

Additional information

No response
@ehmartens ehmartens added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Feb 9, 2022
@emmyoop
Copy link
Member

emmyoop commented Feb 10, 2022

Making a note that this change will come out with dbt-core v1.1.0.

@runleonarun runleonarun added size: small This change will take 1 to 2 days to address dbt-core v1.1 Docs impact for the v1.1 release (April 2022) enhancement Use to add new features to the docs and removed improvement Use this when an area of the docs needs improvement as it's currently unclear labels Feb 10, 2022
@runleonarun
Copy link
Collaborator

Thank you @ehmartens and @emmyoop! I've added this to the docs project board!

@runleonarun runleonarun added the idea Proposes an idea for new content label Feb 23, 2022
@runleonarun
Copy link
Collaborator

runleonarun commented Mar 8, 2022 •
edited
Loading

@ehmartens Hello! The beta for v1.1 will be cut next week for this. Did you want to draft docs for this? I can review and edit them. One caveat is that we are adding versioning so the docs would need to be encapsulated in versioning code like this:

<VersionBlock firstVersion="1.1">

New content for `-- quiet` flag

</VersionBlock>

cc: @jtcohen6

@ehmartens
Copy link
Author

Hi @runleonarun ! I'm so sorry for the delay on this. I'm happy to do this tomorrow morning (Us Eastern time) if there is still a need. Let me know! I can have a PR done by Noon US Eastern Time.

@runleonarun
Copy link
Collaborator

@ehmartens Apologies from me while I try to figure out a process for features created from the dbt community 😄 Anything you could provide would be helpful, even if unpolished. I can clean it up and publish it.

@runleonarun runleonarun self-assigned this Apr 4, 2022
This was referenced Apr 9, 2022
Merged
Merged
@dbeatty10 dbeatty10 mentioned this issue Jan 19, 2024
Merged
2 tasks
mirnawong1 added a commit that referenced this issue Jan 23, 2024
@mirnawong1
Document DBT_PRINT / DBT_NO_PRINT environment variables (#4775)
219c484 
[Preview](https://docs-getdbt-com-git-dbeatty-print-no-print-dbt-labs.vercel.app/reference/global-configs/print-output#suppress-print-messages-in-stdout)

resolves #4776

## What are you changing in this pull request and why?

I checked from v1.7 back to v1.1, and I couldn't get either of these to
work in any version:

Up to 1.5:
```yaml
config:
  no_print: true
```

1.5 and after:
```yaml
config:
  print: false
```

However, the `DBT_NO_PRINT` / `DBT_PRINT` environment variables and
`--no-print` and `--print` CLI flags _do_ work.

So I think the code example for `profiles.yml` was just accidentally
introduced in the following PRs, and we should remove it because it's
not actually an option for any versions.
- #1319
- #3134

For additional context, see:
- [Upgrading to
v1.1](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.1#advanced-and-experimental-functionality)
- [Upgrading to
v1.5](https://docs.getdbt.com/docs/dbt-versions/core-upgrade/upgrading-to-v1.5#behavior-changes)
- #1102
- dbt-labs/dbt-core#4701
- #3122
- #3332

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
@runleonarun runleonarun removed the idea Proposes an idea for new content label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runleonarun runleonarun

Labels
content Improvements or additions to content dbt-core v1.1 Docs impact for the v1.1 release (April 2022) enhancement Use to add new features to the docs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
3 participants
@runleonarun @emmyoop @ehmartens