Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final 0 9 0 prep #643

Merged
merged 4 commits into from
Aug 26, 2022
Merged

Final 0 9 0 prep #643

merged 4 commits into from
Aug 26, 2022

Conversation

joellabes
Copy link
Contributor

@joellabes joellabes commented Aug 19, 2022

Resolves #539

This is a:

  • documentation update
  • bug fix with no breaking changes
  • new functionality
  • a breaking change

All pull requests from community contributors should target the main branch (default).

Description & motivation

Moving files out of the way so that it's easy to see what stuff is left to be dealt with. Getting the width bucket macro out of the way so we don't accidentally delete it 😅

Checklist

  • This code is associated with an Issue which has been triaged and accepted for development.
  • I have verified that these changes work locally on the following warehouses (Note: it's okay if you do not have access to all warehouses, this helps us understand what has been covered)
    • BigQuery
    • Postgres
    • Redshift
    • Snowflake
  • I followed guidelines to ensure that my changes will work on "non-core" adapters by:
    • dispatching any new macro(s) so non-core adapters can also use them (e.g. the star() source)
    • using the limit_zero() macro in place of the literal string: limit 0
    • using dbt.type_* macros instead of explicit datatypes (e.g. dbt.type_timestamp() instead of TIMESTAMP
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@joellabes
Copy link
Contributor Author

@dbeatty10 I'm happy for you to merge and deploy this tomorrow if you're happy, or if there's tweaks you want to make then I'm pretty sure GH will let you accept your own suggestions.

Or if you don't want to release on a Friday, I will aim to put it out on my Monday morning (I don't fly until Monday afternoon)

@joellabes joellabes merged commit a976cdf into main Aug 26, 2022
@joellabes joellabes deleted the final-0-9-0-prep branch August 26, 2022 03:48
@dbeatty10
Copy link
Contributor

👍 @joellabes will leave it for you to deploy at the beginning of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move width_bucket into sql folder
2 participants