Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused test dependencies #1078

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Remove unused test dependencies #1078

merged 2 commits into from
Jul 24, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We don't use these test dependencies even though we declare them.

Solution

Remove them.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jul 20, 2024
@mikealfare mikealfare self-assigned this Jul 20, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 20, 2024
@mikealfare mikealfare marked this pull request as ready for review July 21, 2024 00:05
@mikealfare mikealfare requested a review from a team as a code owner July 21, 2024 00:05
@colin-rogers-dbt colin-rogers-dbt enabled auto-merge (squash) July 24, 2024 04:29
@colin-rogers-dbt colin-rogers-dbt merged commit a52aac6 into main Jul 24, 2024
21 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the remove-freezegun-test-dependency branch July 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @colin-rogers-dbt