Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding redshift profile version of v1 unique_key as list tests #84

Closed
wants to merge 3 commits into from

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Mar 17, 2022

resolves dbt-labs/dbt-core#4858 by putting redshift versions of tests into repo

Description

adds incremental_unique_id_test directory to integration tests applying redshift versions of base postgres tests found in dbt-core

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-redshift next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 17, 2022
@McKnight-42
Copy link
Contributor Author

McKnight-42 commented Mar 17, 2022

Went ahead and had this ready to go for when we merged in the dbt-core postgres/redshift changes in case redshift also had to have a specific profile call even though they both do use postgres.

@McKnight-42 McKnight-42 self-assigned this Mar 17, 2022
@McKnight-42 McKnight-42 marked this pull request as ready for review March 22, 2022 15:51
@McKnight-42
Copy link
Contributor Author

Closing this as #92 was finished before this was merged in.

@McKnight-42 McKnight-42 closed this Apr 8, 2022
@mikealfare mikealfare deleted the mcknight/add_unique_key_tests branch March 1, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant