Fixing version bump bug #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
commented
Dec 7, 2021
| @@ -57,7 +52,7 @@ def _get_dbt_core_version(): | |||
|
|
|||
|
|
|||
| package_name = "dbt-redshift" | |||
| package_version = _get_plugin_version() | |||
| package_version = "1.0.0" | |||
There was a problem hiding this comment.
.bumpversion will take care of updating this now
McKnight-42
approved these changes
Dec 9, 2021
McKnight-42
pushed a commit
that referenced
this pull request
Mar 10, 2022
4 tasks
4 tasks
McKnight-42
added a commit
that referenced
this pull request
Mar 25, 2022
abbywh
pushed a commit
to abbywh/dbt-redshift
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #50
Description
This fixes the issue with the package naming bug we saw when we released and there was no
rcorbappended to the end. Instead this just relies on versionBump to get the package versionChecklist
CHANGELOG.mdand added information about my change to the "dbt-redshift next" section.