Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reports to exposures #137

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Rename reports to exposures #137

merged 2 commits into from
Sep 22, 2020

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Sep 21, 2020 •
edited
Loading

resolves #135, revises #136
see: https://github.com/fishtown-analytics/dbt/pull/2780/files

Description

  • Renames reports to exposures
  • Add exposure: selector method (analogous to source:)

Checklist

  • I have signed the CLA
  • I have generated docs locally, and this change appears to resolve the stated issue
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Sep 21, 2020
@jtcohen6 jtcohen6 force-pushed the feature/rename-reports-to-exposures branch from af1474b to 9bb68eb Compare September 22, 2020 01:40
@jtcohen6 jtcohen6 changed the title Try naive find+replace Rename reports to exposures Sep 22, 2020
drewbanin
drewbanin approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @jtcohen6!! You definitely caught a couple of things that I missed in here - nice work on adding that test too :)

:shipit:

@jtcohen6 jtcohen6 merged commit bc31f75 into master Sep 22, 2020
@jtcohen6 jtcohen6 deleted the feature/rename-reports-to-exposures branch September 22, 2020 12:39
@jtcohen6 jtcohen6 mentioned this pull request Sep 22, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial support for reports
2 participants
@jtcohen6 @drewbanin