Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of env vars for --resource-types and --exclude-resource-types #9779

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Mar 20, 2024

resolves #9237 (follow on pr)

Problem

The MultiOption ChoiceTuple param type didn't support env vars.

Solution

Fix ChoiceTuple to not split strings into characters

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank requested a review from a team as a code owner March 20, 2024 15:59
@cla-bot cla-bot bot added the cla:yes label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (2c1926c) to head (eb704a5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9779      +/-   ##
==========================================
- Coverage   88.11%   88.06%   -0.06%     
==========================================
  Files         178      178              
  Lines       22487    22497      +10     
==========================================
- Hits        19815    19812       -3     
- Misses       2672     2685      +13     
Flag Coverage Δ
integration 85.45% <100.00%> (-0.12%) ⬇️
unit 61.79% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank merged commit cc42ec3 into main Mar 20, 2024
58 checks passed
@gshank gshank deleted the resource_types_env_var branch March 20, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-3467] add environment variable / flag to exclude certain resource types
2 participants