Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --target and --profile command line flags to global config #8996

Closed
wants to merge 2 commits into from

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Nov 3, 2023

This is a starting point for @barton996 for #7798

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Nov 3, 2023
@cla-bot cla-bot bot added the cla:yes label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (7fddd6e) to head (87203ac).
Report is 394 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8996      +/-   ##
==========================================
- Coverage   86.51%   83.39%   -3.12%     
==========================================
  Files         179      179              
  Lines       26508    26510       +2     
==========================================
- Hits        22934    22109     -825     
- Misses       3574     4401     +827     
Flag Coverage Δ
integration 83.39% <100.00%> (-0.02%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbeatty10
Copy link
Contributor Author

Resolved by #9081

@dbeatty10 dbeatty10 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant