Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-974: Fix issue where materialized views were not showing up in catalog queries #8945

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

mikealfare
Copy link
Contributor

resolves #8864

Problem

Materialized views do not show up in catalog queries.

Solution

  • write a test demonstrating the issue
  • update the catalog queries to reflect materialized views

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7317de2) 86.49% compared to head (26be2df) 86.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8945      +/-   ##
==========================================
- Coverage   86.49%   86.47%   -0.02%     
==========================================
  Files         177      177              
  Lines       26405    26405              
==========================================
- Hits        22839    22834       -5     
- Misses       3566     3571       +5     
Flag Coverage Δ
integration 83.26% <ø> (-0.10%) ⬇️
unit 64.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare mikealfare merged commit bb21403 into main Nov 1, 2023
66 checks passed
@mikealfare mikealfare deleted the materialized-views/bug/adap-974 branch November 1, 2023 03:57
github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
…atalog queries (#8945)

* changelog
* write test case demonstrating the issue
* update catalog query to reflect materialized views

(cherry picked from commit bb21403)
github-actions bot pushed a commit that referenced this pull request Nov 1, 2023
…atalog queries (#8945)

* changelog
* write test case demonstrating the issue
* update catalog query to reflect materialized views

(cherry picked from commit bb21403)
mikealfare added a commit that referenced this pull request Nov 1, 2023
…atalog queries (#8945) (#8963)

* changelog
* write test case demonstrating the issue
* update catalog query to reflect materialized views

(cherry picked from commit bb21403)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
mikealfare added a commit that referenced this pull request Nov 1, 2023
…atalog queries (#8945) (#8962)

* changelog
* write test case demonstrating the issue
* update catalog query to reflect materialized views

(cherry picked from commit bb21403)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-974][CT-3230] [Bug] type should not be set to null for dynamic tables and materialized view
2 participants