Add additional functional test for unit testing selection, artifacts, etc #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
requested review from
eddowh,
nathaniel-may and
QMalcolm
and removed request for
a team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## unit_testing_feature_branch #8639 +/- ##
===============================================================
+ Coverage 86.68% 86.77% +0.09%
===============================================================
Files 176 176
Lines 26006 26002 -4
===============================================================
+ Hits 22543 22564 +21
+ Misses 3463 3438 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
changed the base branch from
main
to
unit_testing_feature_branch
MichelleArk
reviewed
Sep 13, 2023
| @@ -118,5 +124,52 @@ def test_basic(self, project): | |||
| results = run_dbt(["run"]) | |||
There was a problem hiding this comment.
^ can't comment one line above but - I don't think the run_dbt(["deps"]) is necessary here
There was a problem hiding this comment.
Right. That was left over from an unnecessary dependency that was removed.
MichelleArk
reviewed
Sep 13, 2023
Comment on lines
+131
to
+141
| # Test select by test name | ||
| results = run_dbt(["unit-test", "--select", "test_name:test_my_model_string_concat"]) | ||
| assert len(results) == 1 | ||
|
|
||
| # Select, method not specified | ||
| results = run_dbt(["unit-test", "--select", "test_my_model_overrides"]) | ||
| assert len(results) == 1 | ||
|
|
||
| # Select using tag | ||
| results = run_dbt(["unit-test", "--select", "tag:test_this"]) | ||
| assert len(results) == 1 |
There was a problem hiding this comment.
What do you think about splitting these assertions into their own test - perhaps test_selection? They will still require the call to run_dbt(["run"]) as well.
There was a problem hiding this comment.
I would prefer that, but having more than one test method per test class leads to flaky tests, which would probably happen here due to the partial parsing test.
MichelleArk
approved these changes
Sep 13, 2023
Merged
5 tasks
gshank
added a commit
that referenced
this pull request
Jan 16, 2024
* Initial implementation of unit testing (from pr #2911) Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * 8295 unit testing artifacts (#8477) * unit test config: tags & meta (#8565) * Add additional functional test for unit testing selection, artifacts, etc (#8639) * Enable inline csv format in unit testing (#8743) * Support unit testing incremental models (#8891) * update unit test key: unit -> unit-tests (#8988) * convert to use unit test name at top level key (#8966) * csv file fixtures (#9044) * Unit test support for `state:modified` and `--defer` (#9032) Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> * Allow use of sources as unit testing inputs (#9059) * Use daff for diff formatting in unit testing (#8984) * Fix #8652: Use seed file from disk for unit testing if rows not specified in YAML config (#9064) Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Fix #8652: Use seed value if rows not specified * Move unit testing to test and build commands (#9108) * Enable unit testing in non-root packages (#9184) * convert test to data_test (#9201) * Make fixtures files full-fledged members of manifest and enable partial parsing (#9225) * In build command run unit tests before models (#9273) --------- Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com> Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com> Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com> Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com> Co-authored-by: Kshitij Aranke <kshitij.aranke@dbtlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8512
Problem
Previous pull request didn't include necessary functional tests.
Solution
Add more functional tests.
Checklist