switch to minimal-snowplow-tracker #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
commented
Jul 18, 2018
requirements.txt
Outdated
| @@ -5,7 +5,7 @@ PyYAML>=3.11 | |||
| psycopg2==2.7.5 | |||
| sqlparse==0.2.3 | |||
| networkx==1.11 | |||
| snowplow-tracker==0.7.2 | |||
| minimal-snowplow-tracker==0.0.1 | |||
There was a problem hiding this comment.
remove other pinned dependencies because of snowplow-tracker (esp celery)
update setup.py, too
cmcarthur
commented
Jul 18, 2018
requirements.txt
Outdated
| @@ -5,7 +5,7 @@ PyYAML>=3.11 | |||
| psycopg2==2.7.5 | |||
There was a problem hiding this comment.
possibly remove argparse?
beckjake
reviewed
Jul 18, 2018
setup.py
Outdated
| 'sqlparse==0.2.3', | ||
| 'networkx==1.11', | ||
| 'snowplow-tracker==0.7.2', | ||
| 'celery==3.1.23', | ||
| 'minimal-snowplow-tracker==0.0.1', | ||
| 'snowflake-connector-python>=1.4.9', | ||
| 'requests>=2.18.0', |
There was a problem hiding this comment.
This should probably be >=2.18.0,<3 - requests is very good about semver but that means any 3.0 will be pretty much guaranteed to break something...
beckjake
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.