Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ModelNodeArgs.fqn #8364

Merged
merged 2 commits into from
Aug 12, 2023
Merged

fix ModelNodeArgs.fqn #8364

merged 2 commits into from
Aug 12, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Aug 11, 2023

resolves #8374
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #8364 (c7433a0) into main (83ff38a) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8364      +/-   ##
==========================================
- Coverage   86.29%   86.25%   -0.05%     
==========================================
  Files         174      174              
  Lines       25529    25535       +6     
==========================================
- Hits        22030    22024       -6     
- Misses       3499     3511      +12     
Flag Coverage Δ
integration 82.99% <33.33%> (-0.13%) ⬇️
unit 65.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/contracts/graph/nodes.py 94.49% <ø> (ø)
core/dbt/contracts/graph/node_args.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@MichelleArk MichelleArk marked this pull request as ready for review August 12, 2023 01:16
@MichelleArk MichelleArk requested a review from a team as a code owner August 12, 2023 01:16
@MichelleArk MichelleArk merged commit 9388030 into main Aug 12, 2023
49 of 50 checks passed
@MichelleArk MichelleArk deleted the fix-model-node-args-fqn branch August 12, 2023 03:21
github-actions bot pushed a commit that referenced this pull request Aug 12, 2023
(cherry picked from commit 9388030)
jtcohen6 added a commit that referenced this pull request Aug 14, 2023
(cherry picked from commit 9388030)

Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2965] fqn selection crashes for external versioned nodes
2 participants