Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7299: dbt retry #7763
Fixes #7299: dbt retry #7763
Changes from all commits
b1b686c
b30ba16
19db36e
45680d4
07b2126
55daee2
46bcce2
4bd5d86
5161bb6
0bb0147
c0940af
1fa9035
dfbb8dd
2e7b6a5
a90d1bb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing that @MichelleArk noticed while investigating #7744 (fix in #7767): If a model is cancelled because of
--fail-fast
, its downstream dependencies will not be recorded as "skipped" inrun_results.json
, and so it won't be retried bydbt retry
.(Repro case:
model_a
->model_b
(with error) ->model_c
.dbt run -x && dbt retry
.model_c
never runs.)Would it make sense to address that here, or to open as a new/separate issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two options:
I prefer the first one and if that's the solution we pick we should do it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is:
--warn-error
, then we will rerun tests or freshness checks that warnedI buy that - let's be sure to document it.