Detect breaking changes to constraints in state:modifed #7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
changed the title
emmyoop
requested review from
nathaniel-may,
stu-k,
peterallenwebb,
aranke,
VersusFacit,
MichelleArk and
mikealfare
and removed request for
a team,
nathaniel-may,
stu-k,
aranke and
VersusFacit
MichelleArk
reviewed
May 9, 2023
MichelleArk
reviewed
May 9, 2023
MichelleArk
reviewed
May 9, 2023
MichelleArk
reviewed
May 10, 2023
MichelleArk
reviewed
May 10, 2023
MichelleArk
reviewed
May 10, 2023
core/dbt/contracts/graph/nodes.py
Outdated
| @@ -608,32 +654,99 @@ def same_contract(self, old) -> bool: | |||
| contract_enforced_disabled: bool = False | |||
| columns_removed: List[str] = [] | |||
| column_type_changes: List[Tuple[str, str, str]] = [] | |||
| enforced_column_constraint_removed: List[List[str]] = [] # column, constraint_type | |||
There was a problem hiding this comment.
any reason not to use a list of Tuple[str, str] here and for enforced_model_constraint_removed? Feels more consistent with the implementation so far (of columns_removed) given the nested lists are of fixed length.
MichelleArk
approved these changes
May 10, 2023
MichelleArk
pushed a commit
that referenced
this pull request
Jul 12, 2023
* added test that fails * added new exception * add partial error checking - needs more specifics * move contract check under modelnode * try adding only enforced constraints * add checks for enforced constraints * changelog * add materialization logic * clean up tests, tweak materializations * PR feedback * more PR feedback * change to tuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7065
Description
Detects breaking changes on state modified to enforced constraints. Accounts for constraints only considered enforced on table & incremental materializations.
Checklist
changie newto create a changelog entry