bigquery parity for statement blocks #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
commented
Sep 18, 2017
dbt/context/common.py
Outdated
| logger.debug(msg) | ||
| def log(msg, info=False): | ||
| if info: | ||
| logger.info(" ↳ " + msg) |
There was a problem hiding this comment.
@cmcarthur i really like this but fear that it will randomly break python2 installations. Will remove
There was a problem hiding this comment.
oh lol yeah it broke circle
cmcarthur
approved these changes
Sep 19, 2017
dbt/adapters/default.py
Outdated
| else: | ||
| _, cursor = cls.execute_one(profile, sql, model_name, auto_begin) | ||
| status = cls.get_status(cursor) | ||
| return status, None |
There was a problem hiding this comment.
default result data was [], now it's None
I really like this approach but I think we should condense the execute / execute_one / execute_and_fetch / add_query APIs into a smaller set of functions. Not blocking for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes the statement block work with the bigquery adapter. This is necessary for implementing introspective materializations which run against bigquery.
TODO: