Ct 488/migrate invalid model tests #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
72 tasks
iknox-fa
suggested changes
Apr 25, 2022
VersusFacit
force-pushed
the
CT-488/migrate_invalid_model_tests
branch
from
adb01cd
to
45d1f5d
Compare
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* First test completed. * Convert and update more test cases. * Complete test migration and remove old files. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to 488.
Description
Converts 011_invalid_data_tests. There were a few tests that had naming did that not reflect what was being test or was testing for the wrong errors functionally. I've corrected that where possible.
I also added a new fixture that allows for adding properties to model dirs. This proves useful for edge cases where you want to override properties or models without overriding the other.
Checklist
changie newto create a changelog entry