fix retry logic failures #5137
Merged
fix retry logic failures #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
requested review from
jtcohen6,
nathaniel-may and
gshank
and removed request for
a team,
iknox-fa and
McKnight-42
iknox-fa
approved these changes
Apr 22, 2022
|
@iknox-fa great catch. I renamed the file but apparently just created a new one. Don't know how that happened. Will clean it up before I merge. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
* fix retry logic failures * changelog * add tests to make sure data is getting where it needs to * rename file * remove duplicate file (cherry picked from commit 31a3f2b)
emmyoop
added a commit
that referenced
this pull request
Apr 25, 2022
* fix retry logic failures * changelog * add tests to make sure data is getting where it needs to * rename file * remove duplicate file
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Apr 25, 2022
* fix retry logic failures * changelog * add tests to make sure data is getting where it needs to * rename file * remove duplicate file (cherry picked from commit 31a3f2b)
emmyoop
added a commit
that referenced
this pull request
Apr 25, 2022
* move deprecation check outside package caching (#5069) * move deprecation check outside package caching * add changelog * fix retry logic failures (#5137) * fix retry logic failures * changelog * add tests to make sure data is getting where it needs to * rename file * remove duplicate file * move unit test to old framework since new one doesn't exist here
emmyoop
added a commit
that referenced
this pull request
Apr 25, 2022
|
backported to |
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
* fix retry logic failures * changelog * add tests to make sure data is getting where it needs to * rename file * remove duplicate file
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5023
Description
While the retry logic got fixed with the last iteration, there has always been a bug that the retry logic would fail since we were never actually returning the result of the retry.
Checklist
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PRchangie newto create a changelog entry