Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index file for docs generation #4995

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 5, 2022

resolves #4984

Description

Includes user contributions for:
dbt-labs/dbt-docs#257
dbt-labs/dbt-docs#235

Also includes:
dbt-labs/dbt-docs#259
dbt-labs/dbt-docs#255
dbt-labs/dbt-docs#261

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@emmyoop emmyoop requested a review from a team as a code owner April 5, 2022 01:09
@cla-bot cla-bot bot added the cla:yes label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop requested a review from jtcohen6 April 5, 2022 01:14
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple changie files in one PR! Cool to know it works

@@ -0,0 +1,7 @@
kind: Docs
body: Bump jekyll from 3.8.7 to 3.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we just use this to build the getdbt styles?

Copy link
Member Author

@emmyoop emmyoop Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's my understanding @jtcohen6. I wasn't sure if I should include a changelog entry for this or not. I can remove it if you think it would be confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine

@emmyoop emmyoop merged commit 3a3bedc into main Apr 11, 2022
@emmyoop emmyoop deleted the er/ct-445-generate-index branch April 11, 2022 16:31
VersusFacit pushed a commit that referenced this pull request Apr 14, 2022
* Update index file for docs generation

* add changelog entries
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
* Update index file for docs generation

* add changelog entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-445] Generate new index.html
2 participants