Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded code in default snapshot materialization #4993

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Remove unneeded code in default snapshot materialization #4993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73b4d28
Rm unneeded create_schema in snapshot mtlzn
jtcohen6 Apr 4, 2022
14f0bc3
Add changelog entry
jtcohen6 Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Under the Hood-20220404-144708.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Under the Hood
body: Remove unneeded create_schema in snapshot materialization
time: 2022-04-04T14:47:08.960642+02:00
custom:
Author: jtcohen6
Issue: "4742"
PR: "4993"
4 changes: 0 additions & 4 deletions core/dbt/include/global_project/macros/materializations/snapshots/snapshot.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@
{%- set strategy_name = config.get('strategy') -%}
{%- set unique_key = config.get('unique_key') %}

{% if not adapter.check_schema_exists(model.database, model.schema) %}
{% do create_schema(model.database, model.schema) %}
{% endif %}

{% set target_relation_exists, target_relation = get_or_create_relation(
database=model.database,
schema=model.schema,
Expand Down