Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add compliation and cache tracking #4912

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Mar 21, 2022

resolves #4625

Description

Add tracking for compilation time and adapter cache population time. The compilation time and adapter cache time will be sent to snowplow events table as separate event under the action runnable.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner March 21, 2022 15:12
@cla-bot cla-bot bot added the cla:yes label Mar 21, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

track(
active_user,
category="dbt",
action="runnable",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we call this runnable_timing (or runnable_task_startup_timing) for better clarity/discoverability down the line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChenyuLInx Nice work! Excited to have this in the beta, so we can start validating the data in advance of the final release.

One thing comes to mind: If we end up merging #4860, it would super valuable to track whether a user has opted into the flag/config added there (cache_selected_only). I don't think we have any general-purpose tracking for all "global" config values on the invocation.

Since that PR isn't yet merged, it doesn't really make sense to support it in this PR. We can follow up with a new field in the schema and in the tracking event calls.

@ChenyuLInx ChenyuLInx merged commit 7cf57ae into main Mar 23, 2022
@ChenyuLInx ChenyuLInx deleted the execution-startup-tracking branch March 23, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-94] Holistic tracking for perceived start-up performance
2 participants