Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cli_vars instead of context to create package and selector renderers #4878

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Use cli_vars instead of context to create package and selector renderers #4878

merged 2 commits into from
Mar 17, 2022

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Mar 16, 2022

resolves #4876

Description

Fix errors rendering vars in packages.yml and selectors.yml.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@gshank gshank requested a review from a team as a code owner March 16, 2022 18:50
@cla-bot cla-bot bot added the cla:yes label Mar 16, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank gshank requested a review from a team as a code owner March 16, 2022 19:54
emmyoop
emmyoop approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gshank gshank added the backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch label Mar 17, 2022
@gshank gshank merged commit 62a7163 into main Mar 17, 2022
@gshank gshank deleted the 4876-vars_in_packages branch March 17, 2022 13:27
github-actions bot pushed a commit that referenced this pull request Mar 17, 2022
@gshank @github-actions
Use cli_vars instead of context to create package and selector render…
8b26bdc 
…ers (#4878)
@github-actions github-actions bot mentioned this pull request Mar 17, 2022
Merged
gshank added a commit that referenced this pull request Mar 21, 2022
@github-actions @gshank
Use cli_vars instead of context to create package and selector render…
88fc45b 
…ers (#4878) (#4886)

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
@jtcohen6 jtcohen6 mentioned this pull request Apr 21, 2022
Closed
1 task
@aranke aranke mentioned this pull request May 20, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

Assignees
No one assigned
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-371] [Bug] CLI vars in packages.yml and selectors.yml don't work.
2 participants
@gshank @emmyoop