only log events in cache.py when --log-cache-events is set #4369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flag is --log-cache-events
26 tasks
nathaniel-may
approved these changes
Nov 30, 2021
Comment on lines
+41
to
+43
| class Cache(): | ||
| # Events with this class will only be logged when the `--log-cache-events` flag is passed | ||
| pass |
There was a problem hiding this comment.
Perfect! Exactly what I would have done.
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
flag is --log-cache-events automatic commit by git-black, original commits: d75ed96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore old logger functionality to exclude caching logs unless explicitly set with the
--log-cache-eventsflag.Checklist
CHANGELOG.mdand added information about my change