add a simple set of graph unit tests for models only #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Jan 26, 2017
| # are EXPECTED | ||
| posix_filepath = '/'.join(split_path(model.rel_filepath)) | ||
| template = jinja.get_template(posix_filepath) | ||
| template_contents = dbt.clients.system.load_file_contents( |
| analysis_dirs, | ||
| "[!.#~]*.sql") | ||
|
|
||
| return self.build_models_from_file_matches( |
There was a problem hiding this comment.
i think we can clean it up even more if we drop the extreme OOP-iness in models.py but this works for now
yu-iskw
pushed a commit
to yu-iskw/dbt
that referenced
this pull request
Aug 17, 2021
Added quote_columns=(true | false) flag to the unique_combination_of_columns.sql macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two very simple tests -- one that just compiles a model like
select * from table, and one that tests a very simple reference. It took me a little while to get started on this. I'll add more tests shortly.Related: #230