Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump requirements, enable the token cache #2698

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Aug 12, 2020

resolves #2613
resolves #2689

Description

Upgrade the snowflake-connector-python library and enable the token cache. We don't have a good way to test this currently, I think we'd need to set up a headless browser (I have no idea what the state of the art there is, I assume they still exist and it's not still selenium).

I did update the unit tests, but they won't save us if the library changes, so when we upgrade it we'll want to test this manually again.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Aug 12, 2020
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are totally reasonable. I haven't been able to test this out locally (Okta <> sandbox Snowflake). I'll get that set up for future version checks. I'm glad you were able to test it out, and I'll ask the OP from #2689 to test out the forthcoming release candidate.

@beckjake beckjake merged commit acb235e into dev/marian-anderson Aug 14, 2020
@beckjake beckjake deleted the fix/snowflake-connector-python-upgrade branch August 14, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants