make full refresh a config item #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/full-refresh-config
branch
from
bfd3fd8
to
13a66f5
Compare
Added integration tests, fixed existing tests
beckjake
force-pushed
the
feature/full-refresh-config
branch
from
13a66f5
to
0fa9d0a
Compare
drewbanin
approved these changes
May 12, 2020
|
|
||
|
|
||
| {% macro should_full_refresh() %} | ||
| {% set config_full_refresh = config.get('full_refresh', false) %} |
There was a problem hiding this comment.
i think the second arg to config.get is the validator, right? Do we even want to supply that here?
There was a problem hiding this comment.
Oops, I always forget it's not just a dict!
| @@ -8,6 +8,6 @@ | |||
| {{ return(relation is not none | |||
| and relation.type == 'table' | |||
| and model.config.materialized == 'incremental' | |||
| and not flags.FULL_REFRESH) }} | |||
| and not should_full_refresh()) }} | |||
drewbanin
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1009
Description
This PR makes full refresh a config item (
full_refresh) in addition to a flag--full-refresh/flags.FULL_REFRESH. The config item can be True, False, or None, and if it's True or False that overrides the flag.I updated dbt's included materializations to check a new macro that examines both the model config and the flag.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.