Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to hide macros in docs #2431

Merged

Conversation

alf-mindshift
Copy link
Contributor

@alf-mindshift alf-mindshift commented May 12, 2020

resolves #2430

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot
Copy link

cla-bot bot commented May 12, 2020

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @alf-mindshift

@beckjake
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label May 12, 2020
@cla-bot
Copy link

cla-bot bot commented May 12, 2020

The cla-bot has been summoned, and re-checked this pull request!

@beckjake
Copy link
Contributor

@alf-mindshift, thanks for your contribution! The unit tests around serialization/deserialization are going to fail, and you'll probably also have to fix the docs generate tests, but this idea generally looks good! Please don't forget to add yourself as a contributor and this PR to CHANGELOG.md when this is ready, so we can give you credit in the release notes.

@alf-mindshift
Copy link
Contributor Author

I rebased on top of octavius-catto. Let me know if I should rebase on top of marian-anderson instead.

@beckjake
Copy link
Contributor

I rebased on top of octavius-catto. Let me know if I should rebase on top of marian-anderson instead.

Please do! octavius-catto is really close to release, so it's bugfixes only right now. Once you do that I'll kick off the tests again

@alf-mindshift alf-mindshift changed the base branch from dev/octavius-catto to dev/marian-anderson May 18, 2020 13:22
@beckjake
Copy link
Contributor

Assuming the Windows tests pass, as I assume they will, I'm going to repair that merge conflict and merge. There's no need to go through all this again for a changelog conflict!

@beckjake beckjake merged commit 75dbb0b into dbt-labs:dev/marian-anderson May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide macro from docs
2 participants