Fix: disabling tracking resets invocation ID (#2398) #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- re-use the same active user - add disable_tracking method that does not reset invocation ID
beckjake
force-pushed
the
fix/disabling-tracking-resets-invocation-id
branch
from
b0cfcfb
to
869bdc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2398
Description
When dbt disabled tracking, it was creating a whole new User object, which in turn reset the invocation_id and the run_started_at. Instead, if there is an existing user object disable that one "live".
To do so, I added a new entry point,
disable_tracking()- this way existing code indbt.mainwill still reset the invocation ID as it already did.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.