use show schemas for snowflake list_schemas (#2166) #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix up the changelog to better reflect releases
drewbanin
approved these changes
Mar 1, 2020
There was a problem hiding this comment.
One comment about error handling, but otherwise this LGTM! This change, plus parallelizing the info schema queries we do make, knocks 5s of the runtime for our internal analytics project!
This was super great, I'm glad we did this. Let's also investigate making the same type of change around listing objects in a schema in a future release (#2174).
Ship it once that error handling change is addressed!
| @@ -81,3 +82,13 @@ def post_model_hook( | |||
| ) -> None: | |||
| if context is not None: | |||
| self._use_warehouse(context) | |||
|
|
|||
| def list_schemas(self, database: str) -> List[str]: | |||
| results = self.execute_macro( | |||
There was a problem hiding this comment.
If the show schemas query fails (ie. because the database does not exist, or because the user does not have permission), the stdout looks like:
snowflake.connector.errors.ProgrammingError: 002043 (02000): SQL compilation error:
Object does not exist, or operation cannot be performed.
Can we catch this error and re-raise something more helpful, like:
Database error while listing schemas in database '<db name>'
Object does not exist, or operation cannot be performed. <---- the database error
…age about what is going on when list_schemas fails
beckjake
force-pushed
the
feature/use-show-schemas-snowflake
branch
from
6d7e453
to
47cef1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2166
Description
Use
show terse schemason snowflake, instead of selecting schemas frominformation_schema.schemata.Checklist
This PR includes tests, or tests are not required/relevant for this PRExisting tests do not break for this PRCHANGELOG.mdand added information about my change to the "dbt next" section.