lazy-load connections (#1584) #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
This LGTM! Something funky happened with the tests but doesn't look particularly related to this PR.
Let's not merge this into LMA - we should either merge it into an 0.15.1 branch or sit on this until LMA is finalized and we create a new 0.15.1 branch. At this point, LMA should only be receiving bugfixes. I was pretty jazzed to get this in for 0.15.0, but 0.15.1 will come out soon enough :)
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584
Lazily open database connections when connections are acquired. It's a little tricky as we have to defer the opening call until connection time, so we stash that in a special object, and if that's what the "handle" is, we call the stored method, which in turn sets the handle.