merged and updated PR for #1031 #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make changes to table_options macro based on testing against a real project.
Change `table_options` to have better error handling.
This resolves the issue that `{{ config(persist_docs=true) }}`
would not raise a useful exception.
pep8
…dbt into dev/stephen-girard
beckjake
force-pushed
the
build/pr-fixup-1285
branch
from
9dc54a7
to
2d84dd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This @darrenhaken's work from #1285 with @drewbanin's merges + fixes, with a new merge + test fix from me. This is up to date with wilt-chamberlain as of this moment, so if I didn't break bigquery in my merge (🤞 ) it should be good to go!