Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix #9005: Allow singular tests to be documented in properties.yml" #10790

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Sep 26, 2024

We noticed that #10744 would break if people's project has data_test defined in the top level schema file.
Reverting for now and will put back with skipping that failure

@ChenyuLInx ChenyuLInx requested a review from a team as a code owner September 26, 2024 23:43
@cla-bot cla-bot bot added the cla:yes label Sep 26, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (d8b1bf5) to head (18b2489).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10790      +/-   ##
==========================================
- Coverage   89.14%   89.10%   -0.04%     
==========================================
  Files         183      183              
  Lines       23321    23258      -63     
==========================================
- Hits        20790    20725      -65     
- Misses       2531     2533       +2     
Flag Coverage Δ
integration 86.32% <100.00%> (-0.11%) ⬇️
unit 62.29% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.29% <100.00%> (+0.07%) ⬆️
Integration Tests 86.32% <100.00%> (-0.11%) ⬇️

@ChenyuLInx ChenyuLInx merged commit 5d32aa8 into main Sep 27, 2024
75 of 78 checks passed
@ChenyuLInx ChenyuLInx deleted the revert-10744-fix_9005 branch September 27, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants