Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --include-saved-query to --export-saved-queries #9629

Closed
Tracked by #9116
jtcohen6 opened this issue Feb 22, 2024 · 2 comments · Fixed by #9605
Closed
Tracked by #9116

Rename --include-saved-query to --export-saved-queries #9629

jtcohen6 opened this issue Feb 22, 2024 · 2 comments · Fixed by #9605
Assignees
@jtcohen6
Labels
enhancement New feature or request Impact: CC Impact: SL semantic Issues related to the semantic layer user docs [docs.getdbt.com] Needs better documentation
Milestone
v1.8

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 22, 2024 •
edited
Loading

See rationale in #9237 (comment)

Acceptance criteria:

Documentation to update:
@jtcohen6 jtcohen6 mentioned this issue Feb 22, 2024
Closed
@jtcohen6 jtcohen6 added enhancement New feature or request semantic Issues related to the semantic layer Impact: SL labels Feb 22, 2024
@jtcohen6 jtcohen6 self-assigned this Feb 22, 2024
@graciegoheen graciegoheen added the user docs [docs.getdbt.com] Needs better documentation label Feb 22, 2024
@graciegoheen graciegoheen added this to the v1.8 milestone Feb 22, 2024
jtcohen6 added a commit that referenced this issue Feb 22, 2024
@jtcohen6
Rename flag + refactor per #9629
3fcbca1
@dbeatty10
Copy link
Contributor

@jtcohen6 is there a project flag in dbt_project.yml for --include-saved-query that needs to be updated as well?

@jtcohen6
Copy link
Contributor Author

@dbeatty10 Good ask. I don't think so, since it doesn't actually change any existing functionality, unless you think the inclusion/exclusion of a saved query NO-OP is a build is a behavior change that could have real impact. Users could always exclude themselves using standard node selection, or our new proposed --exclude-resource-type flag.

jtcohen6 added a commit that referenced this issue Feb 27, 2024
@jtcohen6
Rename flag + refactor per #9629
f3566ba
@jtcohen6 jtcohen6 mentioned this issue Feb 27, 2024
Merged
5 tasks
jtcohen6 added a commit that referenced this issue Feb 27, 2024
@jtcohen6 @MichelleArk
Clearer no-op logging in stubbed SavedQueryRunner (#9605)
865b09b 
* Clearer no-op logging in stubbed SavedQueryRunner

* Add changelog entry

* Fix unit test

* More logging touchups

* Fix failing test

* Rename flag + refactor per #9629

* Fix failing test

* regenerate core_proto_types with libprotoc 25.3

---------

Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
@jtcohen6 jtcohen6 mentioned this issue Feb 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jtcohen6 jtcohen6

Labels
enhancement New feature or request Impact: CC Impact: SL semantic Issues related to the semantic layer user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Milestone
v1.8
Development

Successfully merging a pull request may close this issue.

Clearer no-op logging in stubbed SavedQueryRunner dbt-labs/dbt-core
4 participants
@jtcohen6 @dbeatty10 @graciegoheen @martynydbt