Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3449] interface changes to dbt-core, conversion metric spec changes #9204

Closed
1 task done
WilliamDee opened this issue Dec 4, 2023 · 1 comment
Closed
1 task done
Labels
backport 1.7.latest enhancement New feature or request Impact: SL user docs [docs.getdbt.com] Needs better documentation

Comments

@WilliamDee
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

Add conversion metrics spec properties,

metric:
  ...
  type_params:
    ...
    conversion_type_params:
      entity: _entity_ # required
      base_measure: _measure_ # required
      conversion_measure: _measure_ # required
      calculation: _calculation_type_ # optional. default: conversion_rate. options: conversions(buys) or conversion_rate (buys/visits) + more to come
      window: _time_window_ # optional. default: inf. window to join the two events on. Follows similar format as time windows elsewhere (i.e. 7 days)
      constant_properties: # optional. List of constant properties default: None
        - base_property: _string_ # required. A reference to a dimension/entity of the semantic model linked to the base_measure
          conversion_property: _string_ # same as base above, but to the semantic model of the conversion_measure

Acceptance criteria

  • adds conversion_type_params under Metric.type_params
  • add CONVERSION as a MetricType

Impact to Other Teams

SL

Will backports be required?

Yes, backport to 1.7 latest

Context

No response

@WilliamDee WilliamDee added enhancement New feature or request user docs [docs.getdbt.com] Needs better documentation Impact: SL backport 1.7.latest labels Dec 4, 2023
@github-actions github-actions bot changed the title interface changes to dbt-core, conversion metric spec changes [CT-3449] interface changes to dbt-core, conversion metric spec changes Dec 4, 2023
@WilliamDee
Copy link
Contributor Author

closing in favour of #9203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest enhancement New feature or request Impact: SL user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

1 participant