Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-3448] Conversion Metrics #9203

Closed
1 task done
Tracked by #9116
QMalcolm opened this issue Dec 4, 2023 · 1 comment · Fixed by #9173
Closed
1 task done
Tracked by #9116

[CT-3448] Conversion Metrics #9203

QMalcolm opened this issue Dec 4, 2023 · 1 comment · Fixed by #9173
Assignees
Labels
backport 1.7.latest enhancement New feature or request Impact: CA Impact: SL semantic Issues related to the semantic layer user docs [docs.getdbt.com] Needs better documentation

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Dec 4, 2023

Housekeeping

  • I am a maintainer of dbt-core

Short description

The Semantic Layer Team is adding conversion type metrics to dbt-semantic-interfaces 0.4.latest and 0.5.0. Conversion metrics will be defined in YAML as the following

metric:
  type: conversion # new MetricType
  type_params:
    conversion_type_params:
      entity: _entity_ # required
      calculation: _calculation_type_ # optional. default: conversion_rate. options: conversions(buys) or conversion_rate (buys/visits) + more to come
      base_measure: _measure_ # required
      conversion_measure: _measure_ # required
      window: _time_window_ # optional. default: inf. window to join the two events on. Follows similar format as time windows elsewhere (i.e. 7 days)
      constant_properties: # optional. List of constant properties default: None
        - base_property: _string_ # required. A reference to a dimension/entity of the semantic model linked to the base_measure
          conversion_property: _string_ # same as base above, but to the semantic model of the conversion_measure

Acceptance criteria

People can specify conversion type metrics, which get parsed and output in the semantic_manifest.json. Additionally, metric depends_on values are determined via input measures in metrics, thus base_measure and conversion_measure needs to be fed into this.

Impact to Other Teams

  • Semantic Layer - The semantic layer can't publish about conversion metrics until we support it
  • Cloud artifacts - This change will change the v11 manifest in 1.7

Will backports be required?

Yes, the request is to backport it to 1.7

Context

Depends on dbt-labs/dbt-semantic-interfaces#210

@github-actions github-actions bot changed the title Conversion Metrics [CT-3448] Conversion Metrics Dec 4, 2023
@QMalcolm QMalcolm added semantic Issues related to the semantic layer Impact: SL Impact: CA labels Dec 4, 2023
@QMalcolm
Copy link
Contributor Author

QMalcolm commented Dec 4, 2023

Synced with @graciegoheen and confirmed that we plan on backporting this to 1.7.latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest enhancement New feature or request Impact: CA Impact: SL semantic Issues related to the semantic layer user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants