Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for packages that are not pinned to a specific version #1446

Closed
drewbanin opened this issue May 8, 2019 · 0 comments · Fixed by #1453
Closed

Warn for packages that are not pinned to a specific version #1446

drewbanin opened this issue May 8, 2019 · 0 comments · Fixed by #1453
Assignees
Labels
enhancement New feature or request

Comments

@drewbanin
Copy link
Contributor

Feature

Feature description

When we make breaking changes to repos like dbt-utils, we invariably break someone's project. This happens when people 1) don't specify a version/revision for their package or 2) specify something overly broad, like master.

While this is pretty well documented (we could do a better job of documenting this in the actual packages), dbt should also WARN if a package is specified without a version/revision, or with the revision master. We should additionally add a config (project-level? profile-level? in the packages.yml file?) which opts out of this warning.

Who will this benefit?

Folks that are using packages and don't want external code changes to brick their projects.

@drewbanin drewbanin added the enhancement New feature or request label May 8, 2019
@drewbanin drewbanin added this to the Wilt Chamberlain milestone May 8, 2019
@beckjake beckjake self-assigned this May 10, 2019
beckjake added a commit that referenced this issue May 10, 2019
…nned-packages

Warn on unpinned git packages (#1446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants