Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anonymous event tracking slows down dbt runs when there is no internet connection #1063

Closed
drewbanin opened this issue Oct 15, 2018 · 0 comments · Fixed by #1445
Closed

anonymous event tracking slows down dbt runs when there is no internet connection #1063

drewbanin opened this issue Oct 15, 2018 · 0 comments · Fixed by #1445
Assignees
Labels
bug Something isn't working

Comments

@drewbanin
Copy link
Contributor

Issue

Issue description

dbt's anonymous event tracking will try to send events even when there is no internet connection. In these cases, each ping takes about a second to timeout, adding a meaningful amount of time to every run. This was actually the root cause of this issue: #1002

dbt should either try to fire these events in a background thread, or stop trying to send pings if the first one fails. I think the former is preferable, as these shouldn't be blocking calls even if the pings are successful.

Results

dbt blocked on sending anonymous events, whereas these events should not have measurably impacted the performance of a given dbt run.

System information

0.11.x

The operating system you're running on:
This happened in a Docker container, though I imagine it would happen on any OS

Steps to reproduce

Turn off your wifi and wait

@drewbanin drewbanin added the bug Something isn't working label Oct 15, 2018
@drewbanin drewbanin added this to the Wilt Chamberlain milestone Nov 28, 2018
@beckjake beckjake self-assigned this May 7, 2019
beckjake added a commit that referenced this issue May 9, 2019
…ng-no-hangs

Improve tracking failure handling (#1063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants