Include the database when deciding if two tables are the same in cata…

…log generation

Convert catalog intermediate structure into something more useful
Make comparing manifests to catalogs faster by generating an explicit identifier to id mapping
Make the identifier to unique ID mapping include databases
Convert catalog to use dataclasses/hologram types
Fix unit tests to test what we actually care about
No changes to integration tests means no need to change dbt docs, hooray

core/dbt/contracts/graph/compiled.py

@@ -1,8 +1,6 @@
 from dbt.contracts.graph.parsed import (
     ParsedNode,
     ParsedAnalysisNode,
-    ParsedDocumentation,
-    ParsedMacro,
     ParsedModelNode,
     ParsedHookNode,
     ParsedRPCNode,
@@ -216,8 +214,6 @@ def parsed_instance_for(compiled: CompiledNode) -> ParsedNode:
     CompiledSnapshotNode,
     CompiledTestNode,
     ParsedAnalysisNode,
-    ParsedDocumentation,
-    ParsedMacro,
     ParsedModelNode,
     ParsedHookNode,
     ParsedRPCNode,

core/dbt/contracts/graph/manifest.py

@@ -367,38 +367,6 @@ def get_resource_fqns(self):
 
         return resource_fqns
 
-    def _filter_subgraph(self, subgraph, predicate):
-        """
-        Given a subgraph of the manifest, and a predicate, filter
-        the subgraph using that predicate. Generates a list of nodes.
-        """
-        to_return = []
-
-        for unique_id, item in subgraph.items():
-            if predicate(item):
-                to_return.append(item)
-
-        return to_return
-
-    def _model_matches_schema_and_table(self, schema, table, model):
-        if model.resource_type == NodeType.Source:
-            return (model.schema.lower() == schema.lower() and
-                    model.identifier.lower() == table.lower())
-        return (model.schema.lower() == schema.lower() and
-                model.alias.lower() == table.lower())
-
-    def get_unique_ids_for_schema_and_table(self, schema, table):
-        """
-        Given a schema and table, find matching models, and return
-        their unique_ids. A schema and table may have more than one
-        match if the relation matches both a source and a seed, for instance.
-        """
-        def predicate(model):
-            return self._model_matches_schema_and_table(schema, table, model)
-
-        matching = list(self._filter_subgraph(self.nodes, predicate))
-        return [match.unique_id for match in matching]
-
     def add_nodes(self, new_nodes):
         """Add the given dict of new nodes to the manifest."""
         for unique_id, node in new_nodes.items():

core/dbt/contracts/graph/parsed.py

@@ -219,6 +219,10 @@ class ParsedNodeMandatory(
 ):
     alias: str
 
+    @property
+    def identifier(self):
+        return self.alias
+
 
 @dataclass
 class ParsedNodeDefaults(ParsedNodeMandatory):

core/dbt/helper_types.py

@@ -1,13 +1,16 @@
 # never name this package "types", or mypy will crash in ugly ways
+from datetime import timedelta
+from typing import NewType
+
 from hologram import (
     FieldEncoder, JsonSchemaMixin, JsonDict, ValidationError
 )
 
-from datetime import timedelta
-from typing import NewType
+from dbt.utils import DECIMALS
 
 
 Port = NewType('Port', int)
+Bool = NewType('Bool', bool)
 
 
 class PortEncoder(FieldEncoder):
@@ -37,7 +40,45 @@ def json_schema(self) -> JsonDict:
         return {'type': 'number'}
 
 
-JsonSchemaMixin.register_field_encoders({
+class DecimalEncoder(FieldEncoder):
+    def to_wire(self, value) -> float:
+        return float(value)
+
+    def to_python(self, value):
+        if isinstance(value, DECIMALS):
+            return value
+        try:
+            return DECIMALS[0](value)
+        except TypeError:
+            raise ValidationError(
+                'cannot encode {} into decimal'.format(value)
+            ) from None
+
+    @property
+    def json_schema(self) -> JsonDict:
+        return {'type': 'number'}
+
+
+class BoolEncoder(FieldEncoder):
+    def to_wire(self, value) -> bool:
+        return value
+
+    def to_python(self, value) -> bool:
+        return value
+
+    @property
+    def json_schema(self) -> JsonDict:
+        return {'type': 'boolean'}
+
+
+_ENCODERS = {
     Port: PortEncoder(),
-    timedelta: TimeDeltaFieldEncoder()
-})
+    timedelta: TimeDeltaFieldEncoder(),
+    Bool: BoolEncoder(),
+}
+
+for decimal_type in DECIMALS:
+    _ENCODERS[decimal_type] = DecimalEncoder()
+
+
+JsonSchemaMixin.register_field_encoders(_ENCODERS)