Fix #8836: Add version to fqn when version==0 (#8915)

dbt-labs · Oct 26, 2023 · 4122f6c · 4122f6c
1 parent 6aeebc4
commit 4122f6c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/.changes/unreleased/Fixes-20231026-002536.yaml b/.changes/unreleased/Fixes-20231026-002536.yaml
@@ -0,0 +1,6 @@
+kind: Fixes
+body: Add version to fqn when version==0
+time: 2023-10-26T00:25:36.259356-05:00
+custom:
+  Author: aranke
+  Issue: "8836"
diff --git a/core/dbt/contracts/graph/node_args.py b/core/dbt/contracts/graph/node_args.py
@@ -33,7 +33,8 @@ def unique_id(self) -> str:
     @property
     def fqn(self) -> List[str]:
         fqn = [self.package_name, self.name]
-        if self.version:
+        # Test for None explicitly because version can be 0
+        if self.version is not None:
             fqn.append(f"v{self.version}")
 
         return fqn
diff --git a/tests/unit/test_contracts_graph_node_args.py b/tests/unit/test_contracts_graph_node_args.py
@@ -14,7 +14,7 @@ def test_model_node_args_unique_id_with_version(self) -> None:
             package_name="package",
             identifier="identifier",
             schema="schema",
-            version="1",
+            version=1,
         )
         assert model_node_args.unique_id == "model.package.name.v1"
 
@@ -33,6 +33,16 @@ def test_model_node_args_fqn_with_version(self) -> None:
             package_name="package",
             identifier="identifier",
             schema="schema",
-            version="1",
+            version=1,
         )
         assert model_node_args.fqn == ["package", "name", "v1"]
+
+    def test_model_node_args_fqn_with_version_zero(self) -> None:
+        model_node_args = ModelNodeArgs(
+            name="name",
+            package_name="package",
+            identifier="identifier",
+            schema="schema",
+            version=0,
+        )
+        assert model_node_args.fqn == ["package", "name", "v0"]