Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model-Level Constraints #648

Merged
merged 9 commits into from
Apr 11, 2023
Merged

Model-Level Constraints #648

merged 9 commits into from
Apr 11, 2023

Conversation

peterallenwebb
Copy link
Contributor

resolves #569

Description

Adds BigQuery support for model-level constraints. Core issue: dbt-labs/dbt-core#6754

Checklist

@cla-bot cla-bot bot added the cla:yes label Apr 6, 2023
@peterallenwebb peterallenwebb marked this pull request as ready for review April 6, 2023 14:37
@peterallenwebb peterallenwebb requested a review from a team as a code owner April 6, 2023 14:37
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@peterallenwebb peterallenwebb changed the title Paw/ct 2221 model level constraints Model-Level Constraints Apr 6, 2023
VersusFacit
VersusFacit reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, but I wanna understand some of the thinking here better

@peterallenwebb peterallenwebb merged commit 4a5d648 into main Apr 11, 2023
@peterallenwebb peterallenwebb deleted the paw/CT-2221-model-level-constraints branch April 11, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop left review comments

@VersusFacit VersusFacit VersusFacit left review comments

@McKnight-42 McKnight-42 McKnight-42 approved these changes

@Fleid Fleid Awaiting requested review from Fleid Fleid is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2221] [BigQuery] Add model-level constraints to get_columns_spec_ddl
4 participants
@peterallenwebb @emmyoop @VersusFacit @McKnight-42