Fix MBC2 data saving (F-1 Race, Kirby's Pinball Land, etc.) #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old MBC2 saving routine based on gbMemory the savedata generated/stored on mapper MBC2 to not save correctly. The affected games by this includes F-1 Race, Kirby's Pinball Land, etc. This fixes said issue, by replacing the save routine from gbMemory to gbRam, like the other mapper saving routines. Also changes the savefile size to 512 kB for avoid saving issues with all MBC2 games. Based on the same fix by Steelskin.
|
You're on a roll! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today i've just KO'ed the MBC2 savedata saving issue that was also plaguing VBA-GX, exactly like MBC7 until a day ago.
The old MBC2 saving routine based on
gbMemorycaused the savedata generated/stored on mapper MBC2 to not saved/stored correctly.The affected games by this includes F-1 Race (Grand Prix mode progress), Kirby's Pinball Land (high scores), etc.
This fixes said issue, by replacing the save routine from
gbMemorytogbRam, like the rest of the mapper saving routines. Also changes the savefile size from 256 kB to 512 kB for avoid saving issues with all MBC2 games.Based on my MBC7 saving fix 51702bb, which is also based in the same fix by Steelskin.