-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring #3
Refactoring #3
Conversation
Thanks for helping! One suggestion what do you think about making the What I don't quite like is copying the authentication values into every class. I'd rather put the authentication into its own class singleton and have every class import it, or something similar. |
What do you think of something like this? |
Assuming you're tested it, it looks good to me. Just change the |
I didn't test everything, I need to create a dummy instance first, I'll test it and let you know |
LGTM. Mark it as ready when you're done |
Great job. I've sent you an invite as collaborator so you can push new versions. |
I'm interested in helping with this library.
I followed this to implement more functionalities about posts.
Also I added types and some docs to post methods.
Fell free to review my changes to your api if you want me to change something.