Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for statsV2 #1143

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Added support for statsV2 #1143

merged 1 commit into from
Jul 29, 2024

Conversation

ekorian
Copy link
Contributor

@ekorian ekorian commented Apr 25, 2024 •
edited
Loading

There is now a statsV2 object that appears to be gradually replacing the original stats object.
This patch avoids crashes due to statsV2-only users, and gives priority to statsV2 over stats when both are present.

{
"stats": {"collectCount": 2787, "commentCount": 16000, "diggCount": 22600, "playCount": 1800000, "shareCount": 259}
}

{
"statsV2": {"collectCount": "2787", "commentCount": "15955", "diggCount": "22609", "playCount": "1776621", "shareCount": "259"}
}

@davidteather davidteather changed the base branch from main to v6.4.0 July 29, 2024 19:15
davidteather
davidteather approved these changes Jul 29, 2024
View reviewed changes
Copy link
Owner

@davidteather davidteather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidteather davidteather merged commit dd208c1 into davidteather:v6.4.0 Jul 29, 2024
0 of 2 checks passed
davidteather added a commit that referenced this pull request Jul 29, 2024
@davidteather @lhphat02
@ekorian @bendavidsteel @wu5bocheng
🎉 V6.4.0 🎉 (#1178)
88375b7 
* Fix user.videos crawling issue (#1141)
* added support for statsV2 (#1143)
* Restored functionality for download bytes method (#1174)
* [PlayList] Add playlist to the user scrapy api (#1177)
* bump to 6.4.0

---------

Co-authored-by: Phat Luu Huynh <lhphat.dev@gmail.com>
Co-authored-by: ekorian <korian.edeline@gmail.com>
Co-authored-by: Ben Steel <bendavidsteel@gmail.com>
Co-authored-by: wu5bocheng <wu5bocheng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidteather davidteather davidteather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekorian @davidteather