Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(e2e): remove wait-on to rely on Cypress wait #569

Merged

Conversation

davidlj95
Copy link
Owner

@davidlj95 davidlj95 commented Apr 22, 2024

Issue or need

See #561

Proposed changes

When running locally, discovered that Cypress actually does some retries until starting tests in case the app is not ready.

Given that now apps are served with SSR and start-up times are almost instant, removing the wait-on in CI/CD to decouple baseUrl from there.

Quick reminders

  • 🤝 I will follow Code of Conduct
  • No existing pull request already does almost same changes
  • 👁️ Contributing docs are something I've taken a look at
  • 📝 Commit messages convention has been followed
  • 💬 TSDoc comments have been added or updated indicating API visibility if API surface has changed.
  • 🧪 Tests have been added if needed. For instance, if adding new features or fixing a bug. Or removed if removing features.
  • ⚙️ API Report has been updated if API surface is altered.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on Graphite Graphite

Copy link

📦 Bundle size (Angular v17)

Git ref: 47a66bf434d0c347120cc426284729ce674e3798

Module file Size Base size Difference
ngx-meta-core.mjs 3094 bytes (3.1KiB) 3094 bytes (3.1KiB) No change
ngx-meta-json-ld.mjs 226 bytes (226B) 226 bytes (226B) No change
ngx-meta-open-graph.mjs 869 bytes (869B) 869 bytes (869B) No change
ngx-meta-routing.mjs 839 bytes (839B) 839 bytes (839B) No change
ngx-meta-standard.mjs 768 bytes (768B) 768 bytes (768B) No change
ngx-meta-twitter-card.mjs 470 bytes (470B) 470 bytes (470B) No change
Total 6266 bytes (6.2KiB) 6266 bytes (6.2KiB) No change

Copy link

📦 Bundle size (Angular v16)

Git ref: 47a66bf434d0c347120cc426284729ce674e3798

Module file Size Base size Difference
ngx-meta-core.mjs 3501 bytes (3.5KiB) 3501 bytes (3.5KiB) No change
ngx-meta-json-ld.mjs 386 bytes (386B) 386 bytes (386B) No change
ngx-meta-open-graph.mjs 1220 bytes (1.2KiB) 1220 bytes (1.2KiB) No change
ngx-meta-routing.mjs 1009 bytes (1009B) 1009 bytes (1009B) No change
ngx-meta-standard.mjs 885 bytes (885B) 885 bytes (885B) No change
ngx-meta-twitter-card.mjs 641 bytes (641B) 641 bytes (641B) No change
Total 7642 bytes (7.5KiB) 7642 bytes (7.5KiB) No change

Copy link

📦 Bundle size (Angular v15)

Git ref: 47a66bf434d0c347120cc426284729ce674e3798

Module file Size Base size Difference
ngx-meta-core.mjs 3501 bytes (3.5KiB) 3501 bytes (3.5KiB) No change
ngx-meta-json-ld.mjs 386 bytes (386B) 386 bytes (386B) No change
ngx-meta-open-graph.mjs 1220 bytes (1.2KiB) 1220 bytes (1.2KiB) No change
ngx-meta-routing.mjs 1009 bytes (1009B) 1009 bytes (1009B) No change
ngx-meta-standard.mjs 885 bytes (885B) 885 bytes (885B) No change
ngx-meta-twitter-card.mjs 641 bytes (641B) 641 bytes (641B) No change
Total 7642 bytes (7.5KiB) 7642 bytes (7.5KiB) No change

@davidlj95 davidlj95 marked this pull request as ready for review April 22, 2024 16:36
@davidlj95 davidlj95 merged commit 8992aad into main Apr 22, 2024
21 checks passed
@davidlj95 davidlj95 deleted the stacked/ci-e2e-remove-wait-on-to-rely-on-cypress-wait branch April 22, 2024 16:36
Copy link

🎉 This PR is included in version 1.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant