Fix unit tests in Python 3.10 (Closes: #192) #211
Conversation
|
Thanks for trying to contribute. The tests are unfortunately failing. Did you test against the different versions? I'm happy to merge this once the CI is passing. |
jspricke
force-pushed
the
test_python3_10
branch
from
76923cc
to
18c0f04
Compare
|
I've pushed a new version working on Python 3.9 (Debian stable), 3.10 and 3.11 (Debian unstable). Can you trigger the CI again? The initial patch was for Debian unstable where we don't have older Python versions. |
jspricke
force-pushed
the
test_python3_10
branch
from
18c0f04
to
782a101
Compare
|
This time it looks much better. I feel like the linter should still be fixed, but 3.6 is probably something I have to look at. |
|
Is it allowed that I can push changes to this branch? Because I would probably fix the Python 3.6 error this way. |
|
I just realized that 3.6 has been end of life for a year. Can you just remove it from the CI? I feel like that's probably the best way forward. A separate commit could then probably remove 3.6 support for Parso, but the CI could already be removed. |
|
I've updated the Python versions, can you trigger the CI again? |
jspricke
force-pushed
the
test_python3_10
branch
from
d32ad71
to
7d43001
Compare
|
Unfortunately still some errors. I have tried to change the rules when the tests are run. So I feel like the tests will be run now when anybody not new to GitHub opens a PR. So I feel like you should now be able to see the results quicker. |
Not compatible with Python >= 3.10: pytest-dev/pytest#9195
|
Thanks for changing the CI restrictions. I assume the reduced coverage is ok? (all other tests pass now) |
|
Yeah, coverage doesn't matter as long as it's not something drastic. Thanks a lot! |
No description provided.