Add is_identical for zvals #217
Merged
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
requested changes
Jan 18, 2023
docsrs_bindings.rs
Outdated
| @@ -79,8 +80,8 @@ pub const ZEND_ACC_STRICT_TYPES: u32 = 2147483648; | |||
| pub const ZEND_ISEMPTY: u32 = 1; | |||
| pub const _ZEND_SEND_MODE_SHIFT: u32 = 25; | |||
| pub const _ZEND_IS_VARIADIC_BIT: u32 = 134217728; | |||
| pub const ZEND_MODULE_API_NO: u32 = 20220829; | |||
| pub const USING_ZTS: u32 = 0; | |||
| pub const ZEND_MODULE_API_NO: u32 = 20210902; | |||
There was a problem hiding this comment.
you should use PHP8.2 to generate doc binding
docsrs_bindings.rs
Outdated
| @@ -1,6 +1,6 @@ | |||
| /* automatically generated by rust-bindgen 0.63.0 */ | |||
|
|
|||
| pub const ZEND_DEBUG: u32 = 1; | |||
| pub const ZEND_DEBUG: u32 = 0; | |||
There was a problem hiding this comment.
Please use a PHP version with debug mode
Comment on lines
+330
to
+341
| /// Checks if the zval is identical to another one. | ||
| /// This works like `===` in php. | ||
| /// | ||
| /// # Parameters | ||
| /// | ||
| /// * `other` - The the zval to check identity against. | ||
| pub fn is_identical(&self, other: &Self) -> bool { | ||
| let self_p: *const Self = self; | ||
| let other_p: *const Self = other; | ||
| unsafe { zend_is_identical(self_p as *mut Self, other_p as *mut Self) } | ||
| } | ||
|
|
There was a problem hiding this comment.
This addition is good! 👍🏻
Christian-Rades
force-pushed
the
add-is-identical
branch
from
3a14026
to
33148cd
Compare
Christian-Rades
commented
Jan 18, 2023
Comment on lines
+837
to
+839
| extern "C" { | ||
| pub fn zend_is_identical(op1: *mut zval, op2: *mut zval) -> bool; | ||
| } |
There was a problem hiding this comment.
The diff looks way better now 😅
Christian-Rades
force-pushed
the
add-is-identical
branch
from
33148cd
to
2ce19af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was missing the ability to compare two zvals with PHP's
===operator.To allow for it, I exposed the
zend_is_identicalfunction that the Zend engine maps to the===token.