Fixes expiration date issues on MacOS #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetlen
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to security reasons, MacOS Catalina will now reject certificates with an expiration date longer than 825 days. That's over 2 years, so for a development certificate, it seems like a reasonable timeframe.
IMO, any work to extend it past that date should be focused more on renewal than extending the expiration. Until that kind of work is done, people can also just wipe out their certificates and build new ones. It's not too hard, and only having to do it every two years isn't really that bad.
On the other hand, keeping the expiration at 7000 days makes the generated certificates completely useless for Mac users.
Fixes #39,
Conflicts with #41. -> This change will need to happen to merge both