Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure_server() : added keep_token arg #24

Merged
merged 2 commits into from
Mar 23, 2021
Merged

secure_server() : added keep_token arg #24

merged 2 commits into from
Mar 23, 2021

Conversation

pvictor
Copy link
Collaborator

@pvictor pvictor commented Mar 31, 2020

Hello,

I added keep_token to secure_server() to allow to maintain token in URL and allow refresh. Should solve #23

@jinseob2kim can you test by installing from this branch ?

remotes::install_github("datastorm-open/shinymanager", ref = "keep-token")

and by setting the arg to TRUE like this in your server :

function(input, output, session) {
 secure_server(check_credentials = check_credentials(credentials), keep_token = TRUE)
}

@jinseob2kim
Copy link

I test the feature and All OK!!
Thanks for your update.

@pvictor
Copy link
Collaborator Author

pvictor commented Mar 31, 2020

Good news @jinseob2kim !

The only downside with this is that users can share the url and get access to the app (at least on shiny-server I think), from my point of view that's equivalent to share credentials, so..

What do you think @bthieurmel ?

@bthieurmel bthieurmel merged commit b5567ed into master Mar 23, 2021
@bthieurmel bthieurmel deleted the keep-token branch March 23, 2021 09:00
@bthieurmel
Copy link
Contributor

Merge in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants